Re: fontconfig's BUILDLINK_ABI_DEPENDS

[Thomas Klausner <wiz%netbsd.org@localhost>]

On Tue, Sep 11, 2018 at 09:21:41AM +0000, maya%netbsd.org@localhost wrote:
> On Mon, Mar 12, 2018 at 11:18:24AM +0000, Thomas Klausner wrote:
> > Module Name:	pkgsrc
> > Committed By:	wiz
> > Date:		Mon Mar 12 11:18:01 UTC 2018
> > 
> > Modified Files:
> > Log Message:
> > Recursive bumps for fontconfig and libzip dependency changes.
> > 
> 
> This commit set:
> BUILDLINK_ABI_DEPENDS.fontconfig+=      fontconfig>=2.13.0
> 
> This is problematic.
> 
> As I understand it, a buildlink3.mk's BUILDLINK_ABI_DEPENDS must be
> bumped following a major bump.

Yes. but it also needs to be set if additional dependencies are introduced, as in this case.

Index: buildlink3.mk
===================================================================
RCS file: /cvsroot/pkgsrc/fonts/fontconfig/buildlink3.mk,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -r1.33 -r1.34
--- buildlink3.mk       4 Jun 2013 22:16:02 -0000       1.33
+++ buildlink3.mk       12 Mar 2018 11:15:32 -0000      1.34
@@ -1,4 +1,4 @@
-# $NetBSD: buildlink3.mk,v 1.33 2013/06/04 22:16:02 tron Exp $
+# $NetBSD: buildlink3.mk,v 1.34 2018/03/12 11:15:32 wiz Exp $

 BUILDLINK_TREE+=       fontconfig

@@ -6,10 +6,11 @@
 FONTCONFIG_BUILDLINK3_MK:=

 BUILDLINK_API_DEPENDS.fontconfig+=     fontconfig>=2.10.93
-BUILDLINK_ABI_DEPENDS.fontconfig+=     fontconfig>=2.10.93nb2
+BUILDLINK_ABI_DEPENDS.fontconfig+=     fontconfig>=2.13.0
 BUILDLINK_PKGSRCDIR.fontconfig?=       ../../fonts/fontconfig

 .include "../../devel/zlib/buildlink3.mk"
+.include "../../devel/libuuid/buildlink3.mk"
 .include "../../graphics/freetype2/buildlink3.mk"
 .include "../../textproc/expat/buildlink3.mk"
 .endif # FONTCONFIG_BUILDLINK3_MK


If you try building this with an older fontconfig from pkgsrc, it will
not have libuuid installed, and the build will fail in a weird way.
 Thomas