tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: scanner problem with packages depending on devel/gobject-introspection



I would make it broken at bootstrap. It's very confusing for people to
understand the bug is symlinked PREFIX when it happens, and very few
people will test out packages like this.

Here is a diff:
Index: bootstrap
===================================================================
RCS file: /cvsroot/pkgsrc/bootstrap/bootstrap,v
retrieving revision 1.248
diff -u -r1.248 bootstrap
--- bootstrap	7 Mar 2018 07:34:07 -0000	1.248
+++ bootstrap	1 Aug 2018 18:33:03 -0000
@@ -948,6 +948,10 @@
 	die "\"${prefix}\" already in use, remove it or use a different --prefix"
 fi
 
+if [ -h "${prefix}" ]; then
+	die "\"${prefix}\" being a symlink is not supported"
+fi
+
 if [ -d "${pkgdbdir}/bootstrap-mk-files-"* ]; then
 	die "\"${pkgdbdir}\" already in use, remove it or use a different --pkgdbdir"
 fi



Improvements welcome.


Home | Main Index | Thread Index | Old Index