Re: hplip and avahi-enabled cups-base

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello Manuel,

Manuel Bouyer writes:
> [...]
> thanks
>
> but there seems to be already the logic in print/cups-base/buildlink3.mk:
> pkgbase := cups-base
> .include "../../mk/pkg-build-options.mk"
>
> .if !empty(PKG_BUILD_OPTIONS.cups:Mkerberos)
> .include "../../mk/krb5.buildlink3.mk"
> .endif
>
> .if !empty(PKG_BUILD_OPTIONS.cups:Mdnssd)
> .include "../../net/mDNSResponder/buildlink3.mk"
> .endif
>
> .if ${OPSYS} != "Darwin" && !empty(PKG_BUILD_OPTIONS.cups:Mavahi)
> .include "../../net/avahi/buildlink3.mk"
> .endif
>
> so there's something not working as expected here.
> Is it because pkgbase is set to "cups-base" while options use "cups" ?
> [...]

Nice catch!

If I'm not missing something from reading mk/pkg-build-options.mk...
I think that we'll need to add PKG_OPTIONS.cups to PKG_LEGACY_OPTIONS,
introduce PKG_OPTIONS.cups-base and adjust buildlink3.mk accordingly
and then everything will properly work like before there was just a
single `cups' non-meta package.

I'll try to reproduce that and hopefully commit a patch as discussed
in the next minutes (or, in worst case update the status here).


Thank you!


PS: General side-note, at least when PKG_BUILD_OPTIONS is used,
like in this case, I think it's important that the PKG_OPTION_VAR
is exactly PKG_OPTIONS.<pkgbase>.