Re: cups-base and avahi

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Manuel Bouyer writes:
> Hello,

Hello Manuel,

> [...]
> Index: PLIST
> ===================================================================
> RCS file: /cvsroot/pkgsrc/print/cups-base/PLIST,v
> retrieving revision 1.1
> diff -u -r1.1 PLIST
> --- PLIST	12 Nov 2017 14:10:15 -0000	1.1
> +++ PLIST	22 Jun 2018 14:24:45 -0000
> @@ -41,6 +41,7 @@
>  ${PLIST.apple}libexec/cups/apple/ipp
>  ${PLIST.apple}libexec/cups/apple/ipps
>  ${PLIST.dnssd}libexec/cups/backend/dnssd
> +${PLIST.avahi}libexec/cups/backend/dnssd
>  libexec/cups/backend/http
>  libexec/cups/backend/https
>  libexec/cups/backend/ipp
> Index: options.mk
> ===================================================================
> RCS file: /cvsroot/pkgsrc/print/cups-base/options.mk,v
> retrieving revision 1.1
> diff -u -r1.1 options.mk
> --- options.mk	12 Nov 2017 14:10:15 -0000	1.1
> +++ options.mk	22 Jun 2018 14:24:45 -0000
> @@ -4,7 +4,7 @@
>  PKG_SUPPORTED_OPTIONS=	acl dnssd kerberos pam tcpwrappers
>  PKG_SUGGESTED_OPTIONS=	dnssd kerberos
>  
> -PLIST_VARS+=		apple dbus dnssd ippfind libusb pam
> +PLIST_VARS+=		apple avahi dbus dnssd ippfind libusb pam
>  
>  .if ${OPSYS} == "Darwin"
>  PLIST.apple=		yes
> @@ -34,6 +34,7 @@
>  .include "../../net/avahi/buildlink3.mk"
>  CONFIGURE_ARGS+=	--enable-avahi
>  PLIST.ippfind=		yes
> +PLIST.avahi=		yes
>  .else
>  CONFIGURE_ARGS+=	--disable-avahi
>  .endif
>
>
> As it seems that libexec/cups/backend/dnssd is always present
> with avahi too.
> Does it look right ? 

Yes, this is right, only a minor nitpick: I would change the `avahi'
PLIST_VARS to `dnssd-backend' and then add `PLIST.dnssd-backend= yes'
both for `avahi' and `dnssd' options and change the PLIST entry of
libexec/cups/backend/dnssd to:

 ${PLIST.dnssd-backend}libexec/cups/backend/dnssd 


Thank you!