Re: databases/mariadb55-client and readline

[maya%netbsd.org@localhost]

On Wed, May 23, 2018 at 07:51:14AM +0000, Emmanuel Dreyfus wrote:
> Hello
> 
> This is databases/mariadb55-client from pkgsrc-2018Q1 on NetBSD-7.1.2/i386
> 
> [ 88%] Building CXX object client/CMakeFiles/mysql.dir/mysql.cc.o
> /usr/pkgsrc/databases/mariadb55-client/work/mariadb-5.5.57/client/mysql.cc: In f
> unction 'void initialize_readline(char*)':
> /usr/pkgsrc/databases/mariadb55-client/work/mariadb-5.5.57/client/mysql.cc:2646:
> 38: error: 'rl_completion_func_t' was not declared in this scope
>    rl_attempted_completion_function= (rl_completion_func_t*)&new_mysql_completio
> n;
> 
> I understand rl_completion_func_t should come from 
> /usr/pkg/include/readline/readline.h
> and the offending file actually has #include <readline/readline.h>
> but /usr/include/readline/readline.h is used instead, which does
> not contain rl_completion_func_t
> 
> Any hint on how this should be fixed?
> 
> -- 
> Emmanuel Dreyfus
> manu%netbsd.org@localhost

To elaborate, it was broken by this commit:
https://github.com/NetBSD/src/commit/3307a6cf72e11f11e860fdebbf9f910999c8469d#diff-93e91132fd5254d9fc8ee066c7290ac4

and:
https://github.com/NetBSD/pkgsrc/commit/78e4c0fff01b51e43c4a7ef5b655dfd4dcdd401c#diff-519234c768d6a7b4687a975ab6cfba75

you are using libedit's readline emulation, hence the differences.