tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH] math/lapack patch-aa too much context?



* On 2018-04-05 at 15:53 BST, Dr. Thomas Orgis wrote:

> Am Thu, 5 Apr 2018 16:39:23 +0200
> schrieb Joerg Sonnenberger <joerg%bec.de@localhost>:
> 
> > Sounds like you have one of those broken GNU patch versions that can't
> > deal with asymmetrical context...
> 
> One of those _broken_ GNU patch versions … well … there are not that many
> to choose from among GNU patch versions …
> 
> 	https://unix.stackexchange.com/questions/414542/does-patch-work-with-asymmetric-context
> 
> Interesting quirk. So that is one way to screw up when manually editing
> patch file. An interesting question is what makes a valid unified diff
> file. Was the asymmetric patch-aa created by a run of the (a) diff
> program? I suppose there was manual hacking in there …

pkgsrc patches should always be generated using mkpatches from
pkgtools/pkgdiff to ensure correctness and reduced diff noise on
changes.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com


Home | Main Index | Thread Index | Old Index