Re: [patch] update math/cgal to version 4.11

["Johnny C. Lam" <jlam%NetBSD.org@localhost>]

On Fri, Sep 29, 2017 at 09:11:01PM +0200, Dr. Thomas Orgis wrote:
> diff -x CVS -ruN pkgsrc-cvs/math/cgal/buildlink3.mk pkgsrc/math/cgal/buildlink3.mk
> --- pkgsrc-cvs/math/cgal/buildlink3.mk	2017-08-28 16:11:11.482716857 +0200
> +++ pkgsrc/math/cgal/buildlink3.mk	2017-09-29 19:53:57.676934552 +0200
> @@ -6,13 +6,13 @@
>  CGAL_BUILDLINK3_MK:=
>  
>  BUILDLINK_API_DEPENDS.cgal+=	cgal>=3.9
> -BUILDLINK_ABI_DEPENDS.cgal+=	cgal>=3.9nb30
> +BUILDLINK_ABI_DEPENDS.cgal+=	cgal>=3.9nb31

If the changes are as big as you say, shouldn't this ABI_DEPENDS
be cgal>=4.11?

> --- pkgsrc-cvs/math/cgal/Makefile	2017-08-28 16:11:11.481716857 +0200
> +++ pkgsrc/math/cgal/Makefile	2017-09-29 20:00:01.601781918 +0200
> @@ -1,10 +1,11 @@
>  # $NetBSD: Makefile,v 1.34 2017/08/24 20:03:00 adam Exp $
>  
> -PKGNAME=	cgal-3.9
> -DISTNAME=	CGAL-3.9
> +PKGNAME=	cgal-4.11
> +DISTNAME=	CGAL-4.11
> +EXTRACT_SUFX=	.tar.xz
> -PKGREVISION=	30
> +PKGREVISION=	31

pkgsrc uses PKGREVISION as a differentiator between multiple
packages of the same software version built using different
versions of pkgsrc.  When updating a package to a new version,
the PKGREVISION can be removed, which effectively sets it to
zero (0).

> -$NetBSD: patch-manpage-installation,v 1.2 2016/04/01 12:17:33 jperkin Exp $
> -
> -Align manpage installation path with pkgsrc conventions.
> -
> ---- CMakeLists.txt.orig	2010-09-17 19:00:59.000000000 +0000
> -+++ CMakeLists.txt
> -@@ -325,7 +325,7 @@ set ( CGAL_INSTALL_DOC_DIR "share/doc/${
> -   CACHE STRING "The folder where CGAL documentation and license files will be installed, relative to CMAKE_INSTALL_PREFIX" 
> -   )
> - 
> --set ( CGAL_INSTALL_MAN_DIR "share/man/man1"  
> -+set ( CGAL_INSTALL_MAN_DIR "${CMAKE_INSTALL_MANDIR}/man1"
> -   CACHE STRING "The folder where manual pages for CGAL scripts will be installed, relative to CMAKE_INSTALL_PREFIX" 
> -   )
> - 

I'm surprised this patch isn't still necessary.  Has this been
fixed upstream?

Regards,
-- 
Johnny C. Lam
jlam%NetBSD.org@localhost