tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: ocaml build fix

On Sun, Mar 26, 2017 at 11:02:02PM -0400, Greg Troxel wrote:
> Joerg Sonnenberger <> writes:
> > On Sun, Mar 26, 2017 at 11:48:57AM -0400, Greg Troxel wrote:
> >> ocaml has been broken for NetBSD i386 since before the freeze started.
> >> I am unclear on if there is trouble on other platforms.  NetBSD amd64
> >> and OS X both seem ok.  The problem is that the "raw_spacetime" library
> >> is not built, but it's in the PLIST.  As far as I know, it's only this
> >> PLIST mismatch that is wrong.  The patch below merely omits the
> >> raw_spacetime libs from PLIST on NetbSD i386.
> >
> > I don't think this change makes sense and it is much more likely to hide
> > the real issue. As such,  I am against this patch.
> Do you think it's better that ocaml and all ocaml programs fail to build
> for the branch?   As far as I can tell this is some build detection nit
> and the library isn't being built for some not particularly good reason.

Compared to a patch that silently ignores a wrong OS being picked up?
Actually, yes, I do. I had too much fun dealing with ABI misselection
and things like that to be happy with this patch...


Home | Main Index | Thread Index | Old Index