Re: Fwd: : devel/py-mercurial breakage by extension.mk patch

[Richard PALO <richard%netbsd.org@localhost>]

Le 23/05/16 19:18, Richard PALO a écrit :
> thanks in advance for thoughtful suggestions.
> 

As found with textproc/py-expat, a slight update was needed to ensure
execution only when there are egg-info directories to be corrected
(the last line is indicative too):

> diff --git a/lang/python/extension.mk b/lang/python/extension.mk
> index 6c42078..3207bdb 100644rc/pkgsrc/textproc/iso-codes$ gvim ../../lang/python
> --- a/lang/python/extension.mk
> +++ b/lang/python/extension.mk
> @@ -28,11 +28,7 @@ PYSETUPTESTTARGET?=  test
>  PYSETUPTESTARGS?=      #empty
>  PYSETUPSUBDIR?=                #empty
>  
> -post-install:  fixup-python-writeable-source
> -.PHONY:        fixup-python-writeable-source
> -fixup-python-writeable-source:
> -       ${FIND} ${DESTDIR} -type f \( -perm -g+w -o -perm -o+w \) \
> -           -exec ${CHMOD} go-w '{}' +
> +CHECK_PERMS_AUTOFIX=   yes     # fixup most mode related warnings/errors
>  
>  do-build:
>         (cd ${WRKSRC}/${PYSETUPSUBDIR} && ${SETENV} ${MAKE_ENV} ${PYTHONBIN} \
> @@ -47,6 +43,13 @@ do-test:
>          ${PYSETUP} ${PYSETUPARGS} ${PYSETUPTESTTARGET} ${PYSETUPTESTARGS})
>  .endif
>  
> +privileged-install-hook:       fixup-egg-info
> +.PHONY:        fixup-egg-info
> +fixup-egg-info:        # ensure egg-info directory contents are always 644
> +.    if !empty(EGG_INFODIR) && exists(${DESTDIR}${PREFIX}/${PYSITELIB}/${EGG_INFODIR})
> +       ${FIND} ${DESTDIR}${PREFIX}/${PYSITELIB}/${EGG_INFODIR} -type f \
> +           -exec ${CHMOD} ${SHAREMODE} '{}' +
> +.    endif
>  .endif
>  
>  # PY_NO_EGG suppress the installation of the egg info file (and


-- 
Richard PALO