Re: Githubify and GITHUB_PROJECT with p5- package

[John Nemeth <jnemeth%cue.bc.ca@localhost>]

On Dec 27,  6:49pm, Makoto Fujiwara wrote:
}
} I'd like to githubify devel/p5-Mojo-IOLoop-ForkCall as attached,
} and this patch should work fine, but with only one level simplification.
} 
} Say, GITHUB_PROJECT tweak is necessary, for (default) PKGBASE is p5- 
} prefixed.
} 
} If GITHUB_PROJECT defaults to DISTBASE (which currently does not exist),
} the code gets simpler again.
} 
} 
} Index: devel/p5-Mojo-IOLoop-ForkCall/Makefile
} ===================================================================
} RCS file: /cvs/cvsroot/pkgsrc/devel/p5-Mojo-IOLoop-ForkCall/Makefile,v
} retrieving revision 1.5
} diff -u -r1.5 Makefile
} --- devel/p5-Mojo-IOLoop-ForkCall/Makefile	12 Jun 2015 10:49:28 -0000	1.5
} +++ devel/p5-Mojo-IOLoop-ForkCall/Makefile	27 Dec 2015 09:43:58 -0000
} @@ -1,11 +1,12 @@
}  # $NetBSD: Makefile,v 1.5 2015/06/12 10:49:28 wiz Exp $
}  
} -VERSION=	0.17
} -DISTNAME=	${VERSION}
} -PKGNAME=	p5-Mojo-IOLoop-ForkCall-${VERSION}
} +DISTNAME=	Mojo-IOLoop-ForkCall-0.17
} +# default name ${PKGBASE} has p5- prefix, so (prefer DISTBASE by mef)
} +GITHUB_PROJECT=	Mojo-IOLoop-ForkCall
} +PKGNAME=	p5-${DISTNAME}

     There is too much duplication of information here.  That makes
harder to maintain and error prone.  I would abstract out the
duplicated information like this:

VERSION=	0.17
GITHUB_PROJECT=	Mojo-IOLoop-ForkCall
DISTNAME=	${GITHUB_PROJECT}-${VERSION}
PKGNAME=	p5-${DISTNAME}

With this, there is no duplication of information, and updates can
be done simply by changing VERSION.

}  PKGREVISION=	1
}  CATEGORIES=	devel
} -MASTER_SITES=	https://github.com/jberger/Mojo-IOLoop-ForkCall/archive/
} +MASTER_SITES=	${MASTER_SITE_GITHUB:=jberger/}
}  
}  MAINTAINER=	wiedi%frubar.net@localhost
}  HOMEPAGE=	https://github.com/jberger/Mojo-IOLoop-ForkCall/

     BTW, since there is a MAINTAINER, you should be asking them
directly about changes to the package, not posting here.

     As a side note, the MAINTAINER should change the address to
his .netbsd.org address.

}-- End of excerpt from Makoto Fujiwara