Re: libtorrent/rtorrent patch for testing

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Sat, Oct 10, 2015 at 08:55:07PM +0100, Matthias Scheler wrote:
> On Sat, Oct 10, 2015 at 09:45:34PM +0200, Joerg Sonnenberger wrote:
> > the attached patch does two things:
> > (1) Allowing building both against a C++11 implementation of STL without
> > the TR1 stuff. This is primarily using the correct version of the
> > symbols, but there is an additional change for std::array vs
> > std::tr1::array with the fill vs assign difference.
> > 
> > (2) Fix the kevent udata type issue again for NetBSD.
> > 
> > I have some reports from #pkgsrc that it builds now with GCC and on
> > newer OSX.
> 
> Please do *NOT* apply this patch. It will only make it impossible to
> update "rtorrent". We had the same problem with your previous C++11 patch.
> 
> There is a new version 0.9.6 of "rtorrent" which might already solve
> the problem. There have definitely C++11 related commits to the
> Github repository.

If you had spend even 10sec grepping the source, it would have been
obvious that the update doesn't fix anything. So yes, you just broke a
fix without improving the situation at all.

Joerg