tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Add Mach-O support to check-shlibs



On Fri, Aug 07, 2015 at 10:10:07AM +0100, Jonathan Perkin wrote:
> This commit adds support for Mach-O executables to our check-shlibs
> checks, ensuring that we do not ship packages with broken REQUIRES:
> 
>   https://github.com/joyent/pkgsrc/commit/8d8413b
> 
> check-shlibs-macho.awk is mostly a copy of check-shlibs-elf.awk but
> uses otool(1) to sanitise the list of shared library dependencies.

Thanks. Looks good.

Would it be possible to move the USE_TOOLS+=readelf to
mk/check/check-shlibs.mk (where it's used?)

Other than that I didn't see any issues.
 Thomas


Home | Main Index | Thread Index | Old Index