tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: rfc: fix make distinfo/makesum/mirror-distfiles for conditional distfiles



On Fri, Mar 06, 2015 at 08:47:13PM +0000, Taylor R Campbell wrote:
>    Date: Fri, 6 Mar 2015 18:02:36 +0100
>    From: Marc Espie <espie%nerim.net@localhost>
> 
>    DISTFILES = master_archive.tgz
>    .if $(SOME_OPTION)
>    DISTFILES += file1.tgz
>    .elif $(SOME_OTHER_OPTION)
>    DISTFILES += file2.tgz
>    .else
>    DISTFILES += file3.tgz
>    .endif
> 
>    SUPDISTFILES = file1.tgz file2.tgz file3.tgz
> 
> If you'll excuse the predicted NIH...  Seems to me likely to be
> error-prone: easy to forget to add SUPDISTFILES.  Could do something
> like DISTFILES.option1=file1.tgz and DISTSETS+=option1 to avoid this.

Besides, it's not as if  SUPDISTFILES is such a frequent construct.

In about 10 years of practice, we haven't had any error (on SUPDISTFILES) 
stay in our tree for more than 2 or 3 days, top.


Home | Main Index | Thread Index | Old Index