[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: pkgsrc/mk/pbulk
Greg Troxel <gdt%ir.bbn.com@localhost> writes:
> Jonathan Perkin <jperkin%joyent.com@localhost> writes:
>> * On 2014-07-15 at 22:29 BST, Aleksej Saushev wrote:
>>> Module Name: pkgsrc
>>> Committed By: asau
>>> Date: Tue Jul 15 21:29:39 UTC 2014
>>> Added Files:
>>> pkgsrc/mk/pbulk: pbulk.sh
>>> Log Message:
>>> Add helper script for simplified pbulk setup.
>> Please rename it to pbulk-simple.sh or similar, as I clearly asked for
>> in my review. There are a number of different ways to implement pbulk
>> helper scripts, and it needs to be clear what each does.
>> You should also add your README as a starting point for documenting
>> each approach.
> Jonathan's rationale for naming seems very sensible to me.
Sorry, I have not seen any rationale for naming. Only wish.
> Could you
> rename it, or explain why the -simple or -single name causes problems?
> (It seems we are on the cusp of getting more scripts and pbulk docs,
> which is great!)
"Single" is nonsense since it is more generic, in particular it covers
distributed and pseudo-distributed builds that use shared file system image.
"Simple" is simply wrong since the script is not naive, for start.
Main Index |
Thread Index |