Re: CVS commit: pkgsrc/pkgtools/x11-links

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

From: "OBATA Akio" <obata%lins.jp@localhost>, Date: Sun, 04 May 2014 10:24:33 
+0900

> On Sun, 04 May 2014 07:51:48 +0900, Thomas Klausner <wiz%netbsd.org@localhost>
> wrote:
> 
>> Nothing in particular about this commit, but reading it made me
>> wonder.
>>
>>> Modified Files:
>>>     pkgsrc/pkgtools/x11-links: Makefile
>>>     pkgsrc/pkgtools/x11-links/files: xorg xorg.fontconfig xorg.freetype2
>>>         xorg.glu xorg.libICE xorg.libSM xorg.libX11 xorg.libXau
>>>         xorg.libXcomposite xorg.libXdamage xorg.libXdmcp xorg.libXext
>>>         xorg.libXfixes xorg.libXfont xorg.libXft xorg.libXinerama
>>>         xorg.libXmu xorg.libXpm xorg.libXrandr xorg.libXrender
>>>         xorg.libXres
>>>         xorg.libXt xorg.libXtst xorg.libXv xorg.libdrm xorg.libpciaccess
>>>         xorg.libxcb xorg.pixman xorg.xcb-util xorg.xcursor
>>>
>>> Log Message:
>>> Update to 0.89
>>>
>>> * Support OpenBSD 5.5's Xenocara
>>
>> The diffs are all adding
>> libfoo.so.5.0
>> with varying "foo", "5" and "0".
>>
>> Why doesn't x11-links accept
>> libfoo.so.*
>> instead?
> 
> Then, libfoo.*.dylib also will be required :)
> 
> I've added *.la expansion for Cygwin support,
>   lib/libfoo.a.dll, not lib/libfoo.a
>   bin/cygfoo.dll, not lib/libfoo.so
> 
> So no need to update files for platforms *.la are provided.
> 
> My proposed next changes are:
>   * Only put lib/libfoo.la entries in xorg.* files
>   * If libfoo.la exists, expand it (already implemented)
>   * Otherwise, try to expand manually
>       libfoo.la => libfoo.so, libfoo.so.* for SHLIB_TYPE=ELF
>       libfoo.la => libfoo.dylib, libfoo.*.dylib for SHLIB_TYPE=dylib
>    (stopping, how to determine its prefix whereas missing libfoo.la?)
> 
> 
> Then, next proposed changes are:
>   * Only use x11-links for the case builtin X11 is monolithic
>   * Otherwise, builidlink dynamically
> 
> Because, with modular X11, we can check version of each builtin
> X11 modules and can be handled individually, it is same as other
> buitin package handling other than X11 related packages.
> 
> For that matter, X11_TYPE=modular is ambiguous, because buitin
> X11 is modular in these days, so it should be called as
> X11_TYPE=pkgsrc instead.

Looks very good idea for me.

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3