tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: wip/mk/git-package.mk cleanups



Hi Richard!

Thanks for the patches!

Just one question:

On Thu, May 01, 2014 at 03:34:56PM -0400, Richard Hansen wrote:
> +post-extract: do-git-post-extract
> +.PHONY: do-git-post-extract
> +do-git-post-extract:
> +.if ${GIT_REPOSITORIES:[\#]} > 0
> +     ${RUN}                                                          \
> +     if [ ! -e ${WRKSRC:Q} ] && [ ! -h ${WRKSRC:Q} ]; then           \
> +             ${LN} -s ${GIT_MODULE.${GIT_REPOSITORIES:[1]}:Q}        \
> +                     ${WRKSRC:Q};                                    \
> +     fi;
> +.endif
> +
>  .endif

NetBSD's test documents -e as:
     -e file       True if file exists (regardless of type).
so I wonder why the -h test is needed.

Cheers,
 Thomas


Home | Main Index | Thread Index | Old Index