Re: wip/mk/git-package.mk cleanups

[Aleksej Saushev <asau%inbox.ru@localhost>]

Richard Hansen <rhansen%bbn.com@localhost> writes:

> Attached are some fixes/cleanups to wip/mk/git-package.mk.  I'd
> appreciate it if someone would review them before I commit them to the
> pkgsrc-wip repository (please cc me in any replies).

Please, don't commit any changes to git-package.mk without corresponding
changes to cvs-package.mk and other *-package.mk.

> The main user-visible change is that it is no longer necessary to set
> WRKSRC or GIT_MODULE.foo except in unusual circumstances (e.g., cloning
> two repositories).   Simple packages only need to do this:
>
>     GIT_REPOSITORIES= foo
>     GIT_REPO.foo=     url://to/repo.git
>
> and it will work regardless of the name of the repository in the Git
> URL, the value chosen for ${GIT_REPOSITORIES}, or the value of ${PKGNAME}.
>
> Patches #1 through #7 clean up git-package.mk itself, and patch #8
> cleans up the packages that use git-package.mk.  I have not tried
> building all of the packages affected by patch #8; some of them fail to
> build even without these patches applied.

+#              If ${WRKSRC} doesn't exist by the time post-extract is
+#              run, ${WRKSRC} will be created as a symlink pointing
+#              to ${GIT_MODULE.${GIT_REPOSITORIES:[1]}}.
+#

I'm afraid, it doesn't clean anything up, it only introduces more
divergence to other <vcs>-package.mk.

-# Cache support:
-#   cache file name
+# cache file name

This is outright wrong. First, it removes the only way not to cache
local repositories, and second, it is a huge step back that it inlines
modularized parts back.


-- 
HE CE3OH...