Re: any objections to adding -D_PTHREADS in mk/pthread.builtin.mk and pthread.buildlink.mk

["OBATA Akio" <obache%netbsd.org@localhost>]

On Thu, 10 Oct 2013 14:40:44 +0900, Richard PALO 
<richard.palo%free.fr@localhost> wrote:

> Since this touches pkgsrc/mk hierarchy, before I commit are there any
> objections to the following trivial patches:
> > diff --git a/mk/pthread.buildlink3.mk b/mk/pthread.buildlink3.mk
> > index ab6ee8a..fba35a8 100644
> > --- a/mk/pthread.buildlink3.mk
> > +++ b/mk/pthread.buildlink3.mk
> > @@ -124,7 +124,7 @@ BUILDLINK_API_DEPENDS.${_PKG_PTHREAD}+=     ${_PKG_PTHREAD_D
> >  .    include "${_PKG_PTHREAD_BUILDLINK3_MK}"
> >  BUILDLINK_PREFIX.pthread=              ${BUILDLINK_PREFIX.${_PKG_PTHREAD}}
> >  BUILDLINK_CFLAGS.pthread=              ${BUILDLINK_CFLAGS.${_PKG_PTHREAD}}
> > -BUILDLINK_CPPFLAGS.${_PKG_PTHREAD}?=   -D_REENTRANT
> > +BUILDLINK_CPPFLAGS.${_PKG_PTHREAD}?=   -D_REENTRANT -D_PTHREADS
> >  BUILDLINK_CPPFLAGS.pthread=            ${BUILDLINK_CPPFLAGS.${_PKG_PTHREAD}}
> >  BUILDLINK_LDFLAGS.pthread=             ${BUILDLINK_LDFLAGS.${_PKG_PTHREAD}}
> >  BUILDLINK_LIBS.${_PKG_PTHREAD}?=       -lpthread


Is -D_PTHREADS required even with GNU PTH???

> > diff --git a/mk/pthread.builtin.mk b/mk/pthread.builtin.mk
> > index 733edc9..f326224 100644
> > --- a/mk/pthread.builtin.mk
> > +++ b/mk/pthread.builtin.mk
> > @@ -69,7 +69,7 @@ BUILDLINK_LDFLAGS.pthread+=   -pthread
> >  BUILDLINK_CFLAGS.pthread+=     -pthread
> >  CFLAGS+=                       -D_REENTRANT
> >  .    else
> > -BUILDLINK_CPPFLAGS.pthread+=   -D_REENTRANT
> > +BUILDLINK_CPPFLAGS.pthread+=   -D_REENTRANT -D_PTHREADS
> >  .    endif
> >  .    if ${OPSYS} == "FreeBSD"
> >  BUILDLINK_CPPFLAGS.pthread+=   -D_THREAD_SAFE

Why not put conditionally, same as other platforms?

.    elif ${OPSYS} == "SunOS"
BUILDLINK_CFLAGS.pthread+=      -pthreads
BUILDLINK_LDFLAGS.pthread+=     -pthreads


--
OBATA Akio / obache%NetBSD.org@localhost