Re: pkg_add -f bugfixes

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2013-08-21 at 14:06 BST, Greg Troxel wrote:

> Jonathan Perkin <jperkin%joyent.com@localhost> writes:
> 
> >   
> >   - if (Force)
> >   -         return 1;
> >   -
> >     /* We can only arrive here for explicitly requested packages. */
> >     if (!Automatic && is_automatic_installed(pkg->pkgname)) {
> >             if (Fake ||
> 
> That seems ok to me, but it's a little hard to understand what's going
> on.
> 
> That was added in revision 1.97 by joerg, with the apparent (the commit
> had multiple purposes) comment that it made -f -U less confusing.

Thanks Greg.  As best as I can make out, the '-fU' case is unaffected
by my change - i.e. it (re)installs the package in both cases and
exits 0.

However, I'm again not confident as there may be some corner case here
I'm missing.  A regression suite would be really useful here.. ;)

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com