tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Tweaking installation of R packages



On Tue, 1 Jan 2013 02:13:43 +0200 Mike M. Volokhov wrote:
> On Mon, 31 Dec 2012 19:26:20 +0200 Mike M. Volokhov wrote:
> > Hi,
> > 
> > it's sometimes required to add additional flags to R CMD INSTALL. 
> > Particularly,
> > Rgraphviz [1] package that I'm currently working on requires 
> > --configure-args
> > for setting graphviz path. It seem overkill to create a framework for these
> > options so how about just passing them to R_PKG_INSTALL_ARGS?
> > 
> > RCS file: /cvsroot/pkgsrc/math/R/Makefile.extension,v
> ...
> > -R_PKG_INSTALL_ARGS=        -l ${DESTDIR}${PREFIX}/${R_LIB}
> > +R_PKG_INSTALL_ARGS+=       -l ${DESTDIR}${PREFIX}/${R_LIB}
> 
> After playing with options little bit more I found that the
> following patch may look more consistent:
> 
> RCS file: /cvsroot/pkgsrc/math/R/Makefile.extension,v
> retrieving revision 1.17
> diff -u -r1.17 Makefile.extension
> --- Makefile.extension  11 Sep 2012 23:04:16 -0000      1.17
> +++ Makefile.extension  1 Jan 2013 00:02:56 -0000
> @@ -32,6 +32,9 @@
>  R_INST_DIRS?=                ${R_PKGNAME}
>  R_HOMEPAGE_BASE=     http://cran.r-project.org/web/packages
>  R_PKG_INSTALL_ARGS=  -l ${DESTDIR}${PREFIX}/${R_LIB}
> +.if defined(CONFIGURE_ARGS)
> +R_PKG_INSTALL_ARGS+= --configure-args='${CONFIGURE_ARGS}'
> +.endif
>  
>  GENERATE_PLIST+=     ( cd ${DESTDIR}${PREFIX}; for dir in ${R_INST_DIRS}; do 
> \
>       ${FIND} ${R_LIB}/$${dir} \( -type f -o -type l \) -print; done ) | 
> ${SORT} -u;
> 

Since no one objected this I committed the latest patch. Thanks.

--
Mishka.


Home | Main Index | Thread Index | Old Index