tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/mk



Committed.

On Wed, 11 Jul 2012 21:40:04 +0900, OBATA Akio <obache%netbsd.org@localhost> 
wrote:

Now then, following patch should fix the problem.
I've dug history of bsd.pkg.mk, but I cannot find the reason why modified PATH
must be used here.
It is originally added at r1.1012 (at the time, _PATH_ORIG did not exist yet),
and copy&paste again and again to similar context.

Anyone know about the reason why? or I'll commit later.

Index: mk/bsd.pkg.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mk/bsd.pkg.mk,v
retrieving revision 1.1981
diff -u -r1.1981 bsd.pkg.mk
--- mk/bsd.pkg.mk       24 May 2012 11:34:15 -0000      1.1981
+++ mk/bsd.pkg.mk       11 Jul 2012 12:16:40 -0000
@@ -601,11 +601,9 @@
  #      The additional flags that are passed to the make process.
  #

-# XXX: Shouldn't the $${PATH} be ${PATH} here? This may be related to
-# PR 34470.
  _ROOT_CMD=     cd ${.CURDIR} &&                                        \
                 ${PKGSRC_SETENV} ${PKGSRC_MAKE_ENV}                            
 \
-                       PATH="$${PATH}:"${SU_CMD_PATH_APPEND:Q}         \
+                       PATH=${_PATH_ORIG:Q}:${SU_CMD_PATH_APPEND:Q}    \
                 ${MAKE} ${MAKEFLAGS} _PKGSRC_BARRIER=yes                \
                         PKG_DEBUG_LEVEL=${PKG_DEBUG_LEVEL:Q}            \
                         su-${.TARGET} ${MAKEFLAGS.su-${.TARGET}}




--
OBATA Akio / obache%NetBSD.org@localhost


Home | Main Index | Thread Index | Old Index