Re: NetBSD's sed is not gsed (Was: Re: pkg/45752: security/gnome-keyring does (still) not build)

["OBATA Akio" <obache%netbsd.org@localhost>]

On Sat, 31 Dec 2011 23:57:02 +0900, Joerg Sonnenberger 
<joerg%britannica.bec.de@localhost> wrote:

> On Sat, Dec 31, 2011 at 11:41:57PM +0900, OBATA Akio wrote:
> > Remove TOLLS_PLATFORM.gsed setting from tools.NetBSD.mk, and those issue will 
> > be not relevant
> > and simple solution.
>
> But they have been using gsed for ages, so supposedly are tested and
> working.

It just means "the package should be working", not win assurance.
And it is just talking about one issue.
DEPENDS+=gsed must be changed to USE_TOOLS+=gsed:run and BUILD_DEPENDS+=gsed is 
USE_TOOLS+=gsed.
If no faked OLLS_PLATFORM.gsed setting, it will be just converted mechanically, 
but not.
Then, how and who can do it?  How about new packages?
And reset of TOOLS_PLATFORM in pkgsrc in pkg Makefile is hacking style, should 
not be used so.

I can find USE_TOOLS=gsed in 14 packages' Makefile{,common}, one of them is 
just for SunOS, 7 of them
let to force using gsed from pkgsrc for NetBSD (or unconditionally, too bad).
It means that "NetBSD's sed is compatible with gsed" is not majority in pkgsrc.

Then, if a package does not require gsed on NetBSD, following style should be 
used instead.

.if ${OPSYS} != "NetBSD"
USE_TOOLS+= gsed
.endif

--
OBATA Akio / obache%NetBSD.org@localhost