tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: why is replace.mk complaining about gsed?



On Fri, Dec 09, 2011 at 10:50:01PM +0100, John Marino wrote:
 > >>That depends on what is considered the bug.  I consider comparing
 > >>string variables
 > >>without quotes a dodgy decision at best.  One could consider these
 > >>string comparisons
 > >>without double quotes to be a bug.
 > >You are wrong. If the variables are allowed to be undefined, the correct
 > >approach would be to use :U. Adding random "" is not what make fragments
 > >should use.
 > 
 > Fine.  Would some makefile expert please fix replace.mk in the
 > sanctioned way?

I think the point is that it this combination of defined/undefined
shouldn't be happening, so papering it over so it doesn't fail at this
point is only asking for something more mysterious to go wrong.

-- 
David A. Holland
dholland%netbsd.org@localhost


Home | Main Index | Thread Index | Old Index