Re: pkg/44713, brokennes of GNU patch

[Aleksey Cheusov <cheusov%tut.by@localhost>]

 >> Index: mk/tools/tools.Linux.mk
 >> ===================================================================
 >> RCS file: /cvsroot/pkgsrc/mk/tools/tools.Linux.mk,v
 >> retrieving revision 1.47
 >> diff -u -r1.47 tools.Linux.mk
 >> --- mk/tools/tools.Linux.mk     13 Feb 2010 08:30:59 -0000      1.47
 >> +++ mk/tools/tools.Linux.mk     9 Dec 2011 16:08:55 -0000
 >> @@ -190,9 +190,7 @@
 >>  .if exists(/usr/bin/openssl)
 >>  TOOLS_PLATFORM.openssl?=       /usr/bin/openssl
 >>  .endif
 >> -.if exists(/usr/bin/patch)
 >> -TOOLS_PLATFORM.patch?=         /usr/bin/patch
 >> -.endif
 >> +TOOLS_PLATFORM.patch?=         # pkgsrc version will be used
 >>  .if exists(/usr/bin/printf)
 >>  TOOLS_PLATFORM.printf?=                /usr/bin/printf
 >>  .endif

> Don't set it at all, defining it to empty is just confusing.

Setting TOOLS_PLATFORM.patch to an empty string explicitly (especially
with a comment line and a link to the PR) prevents reappearence of
/usr/bin/patch in the future. Also, this avoids confusions of users
(Why local patch is used if I already have it on my system?).

-- 
Best regards, Aleksey Cheusov.