pkgsrc/mk/tools/replace.mk vs. pkgsrc/archivers/gtar-base/Makefile

[Tim Zingelman <tez%netbsd.org@localhost>]

Anyone see a problem with the following patch to
pkgsrc/mk/tools/replace.mk that makes the name logic for
TOOLS_PATH.gtar match the logic in the
pkgsrc/archivers/gtar-base/Makefile?
(the logic in the makefile says use GNU_PROGRAM_PREFIX unless it is
set to "" in which case override it to "g" (so that gtar does not
conflict with a base tar I suppose.)

Index: tools/replace.mk
===================================================================
RCS file: /usr/cvs/pkgsrc/mk/tools/replace.mk,v
retrieving revision 1.230
diff -w -u -b -r1.230 replace.mk
--- tools/replace.mk    19 Jan 2011 13:05:39 -0000      1.230
+++ tools/replace.mk    20 Jan 2011 22:09:12 -0000
@@ -453,7 +453,11 @@
 TOOLS_DEPENDS.gtar?=           gtar-base>=1.13.25:../../archivers/gtar-base
 TOOLS_CREATE+=                 gtar
 TOOLS_FIND_PREFIX+=            TOOLS_PREFIX.gtar=gtar-base
+.    if defined(GNU_PROGRAM_PREFIX) && ${GNU_PROGRAM_PREFIX} != ""
 TOOLS_PATH.gtar=
${TOOLS_PREFIX.gtar}/bin/${GNU_PROGRAM_PREFIX}tar
+.    else
+TOOLS_PATH.gtar=                ${TOOLS_PREFIX.gtar}/bin/gtar
+.    endif
 .  endif
 .endif

Thanks,

 - Tim