tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: ocaml 3.12.0 natdynlink

On Mon, Oct 11, 2010 at 4:22 PM, Antoine Reilles
<> wrote:

> Ocaml 3.12.0 has a new feature, called natdynlink [1], which allows to
> dynamically load ocaml native code.
> This is currenlty only activated for i386 and x86_64, for linux, freebsd and
> darwin.
> The attached patch add the generated files to the PLIST. This allows to
> build ocaml 3.12.0 packages for macosx 10.5 (at least).
> This feature could probably work on netbsd too, but this is another story.
> It is ok to commit ?

I believe that the list of excluded MACHINE_PLATFORM's is missing
possibly many items, including at least OpenBSD & DragonFly, (and
other might be added anytime.)
It would seem much better to me to have a list of included OPSYS instead...

.if (${MACHINE_ARCH} == "i386") || (${MACHINE_ARCH} == "x86_64")
.  if ${OPSYS} == "FreeBSD" || ${OPSYS} == "Linux" || ${OPSYS} == "Darwin"
PLIST_SRC+=    ${PKGDIR}/PLIST.natdynlink
.  endif

Hope this is helpful,

 - Tim

Home | Main Index | Thread Index | Old Index