Re: Adjusting BUILDLINK_LIBDIRS.${_pkg_} to fix build issues on 64bit linux

["Johnny C. Lam" <jlam88%gmail.com@localhost>]

On Wed, Sep 22, 2010 at 5:58 PM, David Brownlee <abs%absd.org@localhost> wrote:
> The following permits my Centos x86_64 system to successfully build
> packages such as rrdtool, and does not have side effects on non
> 64bit+Linux systems. Does anyone have any objections to it being
> committed?
>
> Index: mk/buildlink3/bsd.buildlink3.mk
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mk/buildlink3/bsd.buildlink3.mk,v
> retrieving revision 1.208
> diff -u -r1.208 bsd.buildlink3.mk
> --- mk/buildlink3/bsd.buildlink3.mk     2 May 2010 18:32:29 -0000       1.208
> +++ mk/buildlink3/bsd.buildlink3.mk     22 Sep 2010 21:19:45 -0000
> @@ -356,7 +356,11 @@
>  BUILDLINK_LDFLAGS.${_pkg_}?=   # empty
>  BUILDLINK_LIBS.${_pkg_}?=      # empty
>  BUILDLINK_INCDIRS.${_pkg_}?=   include
> +.if ${OPSYS} == "Linux"
> +BUILDLINK_LIBDIRS.${_pkg_}?=   lib
> +.else
>  BUILDLINK_LIBDIRS.${_pkg_}?=   lib${LIBABISUFFIX}
> +.endif
>  .  if !empty(BUILDLINK_DEPMETHOD.${_pkg_}:Mfull)
>  BUILDLINK_RPATHDIRS.${_pkg_}?= ${BUILDLINK_LIBDIRS.${_pkg_}}
>  .  else

This doesn't look right to me.  We should be investigating why
LIBABISUFFIX isn't being set correctly on your CentOS x86_64 system
and fixing that instead?

    -- Johnny C. Lam