tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

net/libgdata build failures with non-default options


the attached patch is needed to make net/libgdata build with
PKG_OPTIONS.libgdata = -gnome, because the dependency on libsoup24
is in any case required nowadays.

In principle, the gnome option requires that libsoup24 has been
built with PKG_OPTIONS.libsoup24 = gnome as well. I don't see how
this could be expressed in the Makefile easily. Maybe *-gnome
packages for each of these should be added. On the other hand, in
the form introduced with the patch, libgdata just won't build with
mismatching options, as its configure script will fail with a
message that should be clear enough that users will know what the
issue is, so I'd leave it as is; people will probably either turn
off gnome support globally, or only for packages where this makes
a big difference, so in this particular case, probably close to
nobody will be bitten by this problem.

As this just unbreaks the build in a non-default path, I guessed
a revision bump to be unnecessary.


Dennis den Brok
Index: net/libgdata/Makefile
RCS file: /cvsroot/pkgsrc/net/libgdata/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- net/libgdata/Makefile       9 Dec 2009 10:25:14 -0000       1.2
+++ net/libgdata/Makefile       23 Mar 2010 11:18:42 -0000
@@ -28,14 +28,16 @@
 .include "../../mk/"
 .if !empty(PKG_OPTIONS:Mgnome)
-BUILDLINK_API_DEPENDS.libsoup24+=   libsoup24>=2.26.0
-. include "../../net/libsoup24/"
 CONFIGURE_ARGS+=       --enable-gnome
+CONFIGURE_ARGS+=       --disable-gnome
 .include "../../devel/GConf/"
 BUILDLINK_API_DEPENDS.glib2+=  glib2>=2.19.7
 .include "../../devel/glib2/"
+BUILDLINK_API_DEPENDS.libsoup24+=   libsoup24>=2.26.0
+.include "../../net/libsoup24/"
 .include "../../textproc/gtk-doc/"
 .include "../../textproc/libxml2/"
 .include "../../mk/"

Home | Main Index | Thread Index | Old Index