tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/sysutils/monit



    Date:        Sun, 28 Dec 2008 22:38:08 +0000 (UTC)
    From:        Stoned Elipot <seb%NetBSD.org@localhost>
    Message-ID:  <20081228223808.BA2D7175D0%cvs.netbsd.org@localhost>

  | Log Message:
  | Fix build on NetBSD 3.x: do not use NetBSD's cpp                            
    macro __NetBSD_Prereq__, at least not directly, to                          
    check for NetBSD version 4.99.44 and onward.

This is a necessary change, but why keep the if defined(__NetBSD_Prereq__)
part of it?   That will fail when someone finally gets around to
deleting __NetBSD_Prereq__() (which has become totally useless).

Wouldn't it be better to instead test if __NetBSD_Version__ is defined ?
(or even just NetBSD or __NetBSD__ or whatever that symbol is.)

kre



Home | Main Index | Thread Index | Old Index