Re: Loosing mandatory DISTNAME

["OBATA Akio" <obache%netbsd.org@localhost>]

On Mon, 25 Aug 2008 23:49:44 +0900, Joerg Sonnenberger 
<joerg%britannica.bec.de@localhost> wrote:

> On Mon, Aug 25, 2008 at 09:56:53PM +0900, OBATA Akio wrote:
>> Now, all package must define DISTNAME.
>> But basicall, some kind of packages require no distfile.
>> (meta-package, in-place source, and so on).
>> Those packages now define DISTNAME as PKGNAME, empty MASTER_SITES and
>> DISTFILES. It is circuitous definition.
>
> Huh? They just set DISTNAME, PKGNAME is derived from that. I don't see
> any circular definition.

Yes, but DISTNAME also deliver DISTFILES.
It is not desired effect in this case. 

For example, pkgtools/pkg_install, following patch make it more simply and
viscerally.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/Makefile,v
retrieving revision 1.158
diff -u -r1.158 Makefile
--- Makefile    14 Jul 2008 14:56:50 -0000      1.158
+++ Makefile    26 Aug 2008 00:08:25 -0000
@@ -6,10 +6,8 @@
 # PKGTOOLS_REQD in bsd.pkg.mk. Do so if and only if there is a critical
 # change in the pkg_* tools that pkgsrc relies on for proper operation.

-DISTNAME=              pkg_install-${VERSION}
+PKGNAME=               pkg_install-${VERSION}
 CATEGORIES=            pkgtools
-MASTER_SITES=          # empty
-DISTFILES=             # empty

 MAINTAINER=            joerg%NetBSD.org@localhost
 HOMEPAGE=              http://www.pkgsrc.org/

-- 
"Of course I love NetBSD":-)
OBATA Akio / obache%NetBSD.org@localhost