Re: CVS commit: pkgsrc/mk

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Tue, Jul 22, 2008 at 11:19:57AM +0200, Tobias Nygren wrote:
> On Tue, 22 Jul 2008 00:46:11 +0200
> Joerg Sonnenberger <joerg%britannica.bec.de@localhost> wrote:
> 
> > On Mon, Jul 21, 2008 at 10:34:18PM +0000, Alistair G. Crooks wrote:
> > > Log Message:
> > > Restore default behaviour for creating a symbolic link to the ${WRKDIR},
> > > which was lost when this definition was introduced without prior 
> > > discussion.
> > 
> > Jun 4, 2006. It is not like this was started due to repeated questions
> > about this behavior, like the thread of pkgsrc-users earlier.
> 
> Changing something that has been the default for over a year is not
> exactly good practice either, regardless of the original commit's
> correctness. This is really a bikeshed thing, but since a discussion
> was asked for, here goes:

Indeed. At the same time, relying on my good nature for over a year
is probably not a smart thing to do either.
 
> The use case where _I_ typically set WRKOBJDIR (and DISTDIR and
> PACKAGES) is "I want my pkgsrc tree to be treated as read-only". If we
> postulate that this is true for the majority of users who have
> WRKOBJDIR set, then having the symlinks on by default is not helpful.

I could equally say the same about my usage pattern and extrapolate
that behaviour to all users. Oh, you've already done that.
 
> Also,
> > grep -r SYMLINK pkgsrc/doc | wc -l
>        0

I've fixed this now, but I suggest you complain to the person who
made the previous change (Joerg) without documenting it whatsoever.

Regards,
Alistair