Re: Memory leak in sys/external/bsd/ipf/netinet/ip_fil_netbsd.c:ipf_send_ip()?

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Tue, May 10, 2022 at 06:40:45PM +0200, Edgar Fuß wrote:
> > There is a leak there, but how often does it fire?
> I don't know whether it fires at all.
> On my gateway, for some weeks, I periodically run out of MBuf Clusters every 
> some days (now I know, I monitor mclpl and keep re-booting before actually 
> hitting the limit). Looking for possible leaks, I noticed that IPFilter uses 
> MBuf Clusters to send RST packets. So I dug through the code looking for 
> possible leaks.
> 
> > I think looks like an error if it is not 4 or 6.
> Yes, of course. I didn't figure out whether some malicious packet (which is 
> somewhat likely on a gateway) could be arranged to tigger that case.
> 
> So, as you aggree it's a leak, I'll insert a
> 	FREE_MB_T(m);
> and install the resulting kernel (I'll have to re-boot anyway sometime soon) 
> and see if the problem disappears.

you could also add a printf() to see if this code path is used.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--