Re: Please RUMPify tests in sbin/ifconfig

[Jukka Ruohonen <jruohonen%iki.fi@localhost>]

On Sat, Jul 18, 2020 at 06:05:28AM -0400, Greg Troxel wrote:
> I think it's reasonable and useful to have tests, but it is not ok for
> them to run from "atf-run ." by default.  They need to be opted into
> with some argument that says "run tests that modify the current system,
> which means that they cannot be used except on a system whose entire
> current purpose is testing".

I agree: and when a panic/hang/etc. is explicitly known to occur, a test
case is always skipped. However: if you can crash a system from userland
with standard system utilities, it is always a serious issue. (Fortunately,
privileges are required in these tests, so the issues are not security
bugs.) Trying to hide panics in order to comply with some unwritten test
suite requirements is not only wrong but also dangerous.

- Jukka