Re: CVS commit: src/sys/dev/usb

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Mon, Jun 24, 2019 at 01:30:09PM +1000, matthew green wrote:
> > > splnet is obsolete in modern USB network drivers.
> > > all the code runs at softipl.
> > >
> > > removing spl was done entirely on purpose.
> > 
> > I saw the comment of ether_ioctl in sys/net/if_ethersubr.c
> > > Note, we must be called at splnet().
> > so I asked.
> 
> that comment is true for old style drivers, but looking at other
> drivers they also only skip this for NET_MPSAFE kernel builds.
> 
> Nick, do we need to make these go back to non-mpsafe stuff for
> networking if !NET_MPSAFE?
> 
> eg, look what wm(4) idoes with WM_MPSAFE usage.  are we getting
> ahead of ourselves in usb? :)

I think so. It NET_MPSAFE is not defined, AFAIK the network layers
still need to be called at splnet().

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--