tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Bug in urtwn_llt_init()?



Looking at the end of urtwn_llt_init(), we see:

        /*
         * Use pages [page_count + 1; pktbuf_count - 1]
         * as ring buffer.
         */
        for (++i; i < pktbuf_count - 1; i++) {
                if ((error = urtwn_llt_write(sc, i, i + 1)) != 0)
                        return error;
        }
        /* Make the last page point to the beginning of the ring buffer. */
        error = urtwn_llt_write(sc, i, pktbuf_count + 1);

Shouldn't that last line read:

       error = urtwn_llt_write(sc, i, page_count + 1);

?  Otherwise, I don't see how it ends up as a ring buffer.

-- thorpej



Home | Main Index | Thread Index | Old Index