Re: apparently missing locking in if_bnx.c

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Tue, Mar 06, 2012 at 01:01:09PM +0100, Manuel Bouyer wrote:
> On Tue, Mar 06, 2012 at 06:53:42AM -0500, Beverly Schwartz wrote:
> > I was using the tip of netbsd-6.  I can test it again to be sure.
> 
> You should add tests to make sure that:
> - bnx_start() is always called at splnet():
>   KASSERT(curcpu()->ci_level >= IPL_NET);
> - bnx_start() is always called with KERNEL_LOCK held:
>   KASSERT(ci->ci_biglock_count > 0);

make that:
   KASSERT(curcpu()->ci_ilevel >= IPL_NET);
   KASSERT(curcpu()->ci_biglock_count > 0);

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--