tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: MPLS patches



On Thu, Jan 03, 2008 at 08:10:17PM +0200, Mihai Chelaru wrote:
>> In ether_input, you disable the check for maximum frame size, why?
>
> Hi,
>
> Over ethernet, MPLS uses a 4 size header prepended between data and network 
> layer. I wanted to be sure that ether_input() won't drop these baby giant 
> frames.

You could also change the check macro to correctly deal with this.

>> Have you tested that the checksumming is
>> done correctly?
>
> Yes, mostly, I haven't seen much problems (except HW cksumming I've fixed 
> sometime ago).

If possible make it work without the additional hard-wired case for
disabling HW cksumming.

Joerg



Home | Main Index | Thread Index | Old Index