tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: MPLS patches

On Thu, Jan 03, 2008 at 05:53:54PM +0200, Mihai Chelaru wrote:
> Opinions ?

In ether_input, you disable the check for maximum frame size, why?

In ip_output, you are destroying the indentation. I don't like the chunk
for 480/493 (in_broadcast). Have you tested that the checksumming is
done correctly?

I wonder if some of the code above is cleaner if MPLS_IS_TAGGED is
always defined and just returns false for the !MPLS case.


Home | Main Index | Thread Index | Old Index