tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: if_ethersubr.c: if_ierrors -> if_iqdrops?



In article <3360841c-e7fc-147d-1347-fe427d41a2f2%SDF.ORG@localhost>,
RVP  <rvp%SDF.ORG@localhost> wrote:
>On Mon, 8 Nov 2021, Jason Thorpe wrote:
>
>>> On Nov 7, 2021, at 11:07 PM, RVP <rvp%SDF.ORG@localhost> wrote:
>>>
>>> So, I hacked up a small patch to put most of these into the
>>> "if_iqdrops" bucket. The rest (following FreeBSD) remain as errors.
>>
>> LGTM!
>>
>
>On Mon, 8 Nov 2021, Christos Zoulas wrote:
>
>>> As far as I'm concerned, you can silently chuck most of these errors
>>> away--like FreeBSD does, or classify them as "dropped" like Linux does.
>>> Either way is fine with me--just not "if_ierrors": that's too confusing.
>>
>> I think that the patch makes sense...
>>
>
>OK, so discarded packets are fine as `if_iqdrops'. Otherwise, a kernel w/o
>vlan (or netatalk, carp, ...) compiled in will show:

Yes, I think that we need the distinction between discard and drop...
Or we should just not count discard...

christos



Home | Main Index | Thread Index | Old Index