tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: if_ethersubr.c: if_ierrors -> if_iqdrops?



In article <117a1e3-a48e-a4e0-b60-dc8485a8e768%SDF.ORG@localhost>,
RVP  <rvp%SDF.ORG@localhost> wrote:
>After noticing for some time now, an excessive no. of errors in my
>alc(4) card's stats, this weekend, I decided to find out what
>ailed it. But after poking around adding printf()s all over the
>shop and comparing against 9.2_STABLE, FreeBSD-13.0 and Linux 5.0.0,
>I figured out that there was nothing wrong with my card or with my
>cables.
>
>---
>alc0 at pci2 dev 0 function 0: Atheros AR8162 PCIe Fast Ethernet
>alc0: interrupting at ioapic0 pin 19
>alc0: Ethernet address 50:46:5d:32:67:54
>atphy0 at alc0 phy 0: Atheros AR8035 10/100/1000 PHY, rev. 9
>---
>
>Turns out, in 9.99.X, if_ethersubr.c is classifying all dropped/
>unprocessed packets as "errors". Most of these error packets
>were etype 0x88CA (TIPC (Transparent Inter Process Communication,)
>or 0x893A (IEEE 1905) generated by other devices on the home LAN.
>
>So, I hacked up a small patch to put most of these into the
>"if_iqdrops" bucket. The rest (following FreeBSD) remain as errors.
>
>As far as I'm concerned, you can silently chuck most of these errors
>away--like FreeBSD does, or classify them as "dropped" like Linux does.
>Either way is fine with me--just not "if_ierrors": that's too confusing.

I think that the patch makes sense...

christos



Home | Main Index | Thread Index | Old Index