tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: protect pmf from network drivers that don't provide if_stop

On Tue, Jun 29, 2021 at 11:16:37AM +0200, Martin Husemann wrote:
> On Tue, Jun 29, 2021 at 03:46:20PM +0930, Brett Lymn wrote:
> > I turned up a fix I had put into my source tree a while back, I think at
> > the time the wireless driver (urtwn IIRC) did not set an entry for
> > if_stop.
> This is a driver bug, we should not work around it but catch it early
> and fix it.

ok but I believe that it is a common issue with the usb wifi drivers which is a bit odd
since they are more likely to be attached to platforms that sleep.

> Side note: the wifi drivers fiddling with struct ifnet will stop
> once the new wifi code gets into the main tree.

Is that going to be soon? I was thinking of doing a sweep of the usb network drivers to fix
this.  It is not affecting me at the moment because the driver for wireless I am using at
the moment actually defines if_stop.

Brett Lymn
Sent from my NetBSD device.

"We are were wolves",
"You mean werewolves?",
"No we were wolves, now we are something else entirely",

Home | Main Index | Thread Index | Old Index