tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: to check timer availability in shutdown sequence



> On Jun 25, 2020, at 8:58 PM, SAITOH Masanobu <msaitoh%execsw.org@localhost> wrote:
> 
> The shutting_down variable is new and many drivers don't use it yet.
> Should we replace
> 
> 	if (cold)
> 
> to
> 	if (cold || shutting_down)
> 
> Or any other solutions? (e.g setting cold = 1 after splhigh()).

Perhaps we should abstract this, and replace the uses of "cold" that would need to check both?  Or perhaps functions like kpause() could handle this internally?

I would not suggest setting "cold = 1" at shutdown.

-- thorpej



Home | Main Index | Thread Index | Old Index