Re: semaphores options

[Paul Goyette <paul%whooppee.com@localhost>]

On Mon, 8 Apr 2019, Greg A. Woods wrote:

> Indeed, something seems to have changed, and the problem continues with
> -current as of late January (8.99.32).
>
> I think the culprit was this change, which somehow didn't have an
> accompanying change to any documentation (most notably options(4) still
> documents all the removed settings):
>
> RCS file: /cvs/master/m-NetBSD/main/src/sys/conf/param.c,v
> ----------------------------
> revision 1.65
> date: 2015-05-12 19:06:25 -0700;  author: pgoyette;  state: Exp;  lines: +4 -2;  commitid: G8nWAd1qbrsX8ely;
> Create a new sysv_ipc module to contain the SYSVSHM, SYSVSEM, and
> SYSVMSG options.  Move associated variables out of param.c and into
> the module's source file.
> ----------------------------
>
> This commit adds a great big ugly "#if XXX_PRG" around all the related
> SysV IPC settings in sys/conf/param.c, i.e. it entirely removes all
> support for "options SEMMNI=NNN" and related.

That entire block of code should have been removed, not just #ifdef'd

My bad, I will fix.  Unfortunately I have some personal business to
attend to tonight and tomorrow, so it might be a couple of days before
I can get to it.

> The real underlying problem may be that none of the SysV IPC options
> from options(4) where ever properly set up with "defflag" or "defparam"
> in the appropriate "files" file (sys/kern/files.kern probably), or as we
> used to say, they were never "defopt'ed" for config.  See config(5).
>
> Having "options FOO=1234" worked without "defparam" if the use was in
> sys/conf/param.c, but it doesn't seem to work with the new regime.
> Maybe it would work again if "defparam" lines were added to the right
> place.

Yeah, all of these params should have been defparam'd into opt_sysv.h 
Again, I will fix as soon as I can get to it, within the next couple of
days.

I will also request pullups to -8


Thanks, Greg, for the detailed analysis and suggestions!



+--------------------+--------------------------+-----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
+--------------------+--------------------------+-----------------------+