Re: ppb(4) related changes

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

On 2019/01/28 20:57, Jonathan A. Kollasch wrote:
> On Mon, Jan 28, 2019 at 07:34:29PM +0900, Masanobu SAITOH wrote:
> >   Hi.
> >
> >   I'm now working to modify PCI bridge stuff. I'd like to do the following
> > two modifications:
> >
> >   0) ppbreg.h definitions
> >
> >      All of PCI configuration space's register definitions are in pcireg.h
> >      The ppbreg.h file also defines the same config registers. I think it's
> >      good to remove ppbreg.hs' definitions an use pcireg.h's definitions.
> >      Is it OK?
>
> Seems reasonable, although be sure to fix everything that includes it.

 Done in the following commit:

	http://mail-index.netbsd.org/source-changes/2019/03/01/msg103859.html

BTW, while modifying rbus_ppb.c, I might find a bug:

@@ -278,8 +278,8 @@ rbus_pci_addr_fixup(struct ppb_cardbus_s
        }

        rct.bussize_ioreqs[minbus] =
-         rbus_round_up(rct.bussize_ioreqs[minbus], 4096);
-       rct.bussize_memreqs[minbus] =
+         rbus_round_up(rct.bussize_ioreqs[minbus], PCI_BRIDGE_IO_MIN);
+       rct.bussize_memreqs[minbus] =  /* XXX Not 8 but PCI_BRIDGE_MEM_MIN ? */
          rbus_round_up(rct.bussize_memreqs[minbus], 8);

        printf("%s: total needs IO %08zx and MEM %08zx\nT",

I suspect the above "8" is wrong. It might be PCI_BRIDGE_MEM_MIN (0x00100000UL).
I did not change it and left the comment. If there is anyone who can check
and fix, please feel free to change.

 Thanks.

--
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)