tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Proposal: rename min/max -> umin/umax




> On Aug 5, 2018, at 9:32 AM, Taylor R Campbell <campbell+netbsd-tech-kern%mumble.net@localhost> wrote:
> 
> I propose we rename libkern's min/max to umin/umax.  The names min and
> max invite general use like MIN and MAX, but these functions truncate
> their arguments to unsigned first.  We also have imin/imax, lmin/lmax,
> and ulmin/ulmax.
> 
> This came to my attention while working on a drmkms update, where
> Linux's min/max are generic, and a quick grep found, for example:
> 
> https://nxr.netbsd.org/xref/src/sys/uvm/uvm_pglist.c#151
> 
> Objections?

Sounds like a good change.

-- thorpej



Home | Main Index | Thread Index | Old Index