Re: xhci spec (mis?)interpretation on hubs

[Nick Hudson <skrll%netbsd.org@localhost>]

On 12/20/17 12:18, Sprow wrote:
> In article <3ef1728a-54fb-6c89-5634-e39ca9808d18%netbsd.org@localhost>,
>     Nick Hudson <skrll%netbsd.org@localhost> wrote:

> > How so?
> It used to read
>
> #define IS_TTHUB(dd) \
>      ((dd)->bDeviceProtocol == UDPROTO_HSHUBSTT || \
>       (dd)->bDeviceProtocol == UDPROTO_HSHUBMTT)
>
> then I applied
>
> -#define IS_TTHUB(dd) \
> -    ((dd)->bDeviceProtocol == UDPROTO_HSHUBSTT || \
> +#define IS_MTTHUB(dd) \
>
> leaving me with
>
> #define IS_MTTHUB(dd) \
>       (dd)->bDeviceProtocol == UDPROTO_HSHUBMTT)
>
> which is missing a bracket.
I must have sent you a bad patch... Here's what's committed...

1.83 
<http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/usb/xhci.c?only_with_tag=MAIN#rev1.83>     ! skrll    3188: #define IS_MTTHUB(dd) \
        !          3189:      ((dd)->bDeviceProtocol == UDPROTO_HSHUBMTT)

Nick