tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: x86: per-cpu tmp vas



Maxime Villard <max%m00nbsd.net@localhost> wrote:
> ...
> 
> This patch fixes the two aforementioned issues: the VAs are allocated
> proportionally to the number of CPUs attached so we don't uselessly lose
> memory, and there is no false sharing since the cpu_info structures are
> already cache-line-aligned (and so is their content).
> 
> I just wanted to know if someone had suggestions or whatever before I
> commit it.

Certainly a good change to make.

> 
> Maxime
> 
> [1] http://m00nbsd.net/garbage/vpage/vpage.diff

In pmap_vpage_cpualloc():

+		vabase = uvm_km_alloc(kernel_map, vrange, vrange,
+		    UVM_KMF_VAONLY);

Why alignment is set to vrange?

-- 
Mindaugas


Home | Main Index | Thread Index | Old Index