tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Vnode API cleanup pass 2a



   Date: Mon, 13 Jan 2014 16:06:02 +0100
   From: J. Hannken-Illjes <hannken%eis.cs.tu-bs.de@localhost>

   On Jan 13, 2014, at 8:39 AM, David Holland 
<dholland-tech%netbsd.org@localhost> wrote:

   > On Tue, Jan 07, 2014 at 11:30:40AM +0100, J. Hannken-Illjes wrote:
   >>> (also, while this is minor I think I'd rather have vop_mkdir_args_v2
   >>> and/or vop_mkdir_desc_v2 rather than vop_mkdir2_args and
   >>> vop_mkdir2_desc. The version doesn't need to be part of the operation
   >>> name.)
   >> 
   >> Looks very good -- changed vnode_if.sh to create xxx_v2_args. Diff 
attached.
   > 
   > Would you mind committing the versioning logic right away? It has
   > clear value and it would be nice for it to appear in a separate
   > changeset.

   Done.

As is, existing code calling, e.g., VOP_MKDIR will still compile.  Is
there a reason the versioning doesn't rename it to VOP_MKDIR_V2?


Home | Main Index | Thread Index | Old Index