tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Vnode API cleanup pass 2a



On Jan 7, 2014, at 5:29 AM, David Holland <dholland-tech%netbsd.org@localhost> 
wrote:

<snip>

>>> Plus I think it would be advisable to make this change first, so that
>>> in case we do find a site where it matters we can lock the returned
>>> object before anyone else can see it:
>>> 
>>> #
>>> -#% mkdir      dvp     L U U
>>> +#% mkdir      dvp     L L L
>> 
>> Where should it matter? VOP_MKDIR is only used from:
>> 
>> external/cddl/osnet/dist/uts/common/fs/zfs/zfs_replay.c:zfs_replay_create()
>> sys/kern/vfs_syscalls.c:do_sys_mkdirat()
>> sys/nfs/nfs_serv.c:nfsrv_mkdir()
>> sys/fs/union/union_vnops.c:union_mkdir()
>> sys/fs/union/union_subr.c:union_mkshadow()
>> sys/rump/librump/rumpvfs/rumpvnode_if.c:RUMP_VOP_MKDIR()
>> 
>> and I don't see any problems here.
> 
> I have been putting off answering this because I ought to examine all
> these, and I haven't managed to do so yet but figured I ought to
> answer the rest.

Please do -- plan is to commit next monday, 2014-01-13

--
J. Hannken-Illjes - hannken%eis.cs.tu-bs.de@localhost - TU Braunschweig 
(Germany)



Home | Main Index | Thread Index | Old Index