re: ncr53c9x fallout from asserting kernel lock in scsipi_base

[matthew green <mrg%eterna.com.au@localhost>]

> On Fri, Mar 09, 2012 at 02:49:43PM +0000, Julian Coleman wrote:
> > Hi,
> > 
> > After the change in revision 1.156 of src/sys/dev/scsipi/scsipi_base.c to
> > assert that the kernel lock is held in scsipi_lookup_periph(), my SBus-based
> > sparc64 crashed with:
> > 
> >   panic: kernel diagnostic assertion "KERNEL_LOCKED_P()" failed: file 
> > "/usr/src/sys/dev/scsipi/scsipi_base.c", line 221
> > 
> > The backtrace is:
> > 
> >   kern_assert
> >   scsipi_lookup_periph
> >   scsipi_async_event
> >   ncr53c9x_update_xfer_mode
> >   ncr53c9x_init
> >   ncr53c9x_attach
> > 
> > The attached allows it to boot and run, but is it correct?
> 
> assuming ncr53c9x is MP-safe, it is correct.

it isn't, but these happen during the non-interrupt driven autoconfig
phase and kernel lock isn't held here.


.mrg.